Skip to content

Add xr_cnvcld flag to namelist and configure files#1

Merged
yangfanglin merged 2 commits into
yangfanglin:dycore_update_hr4from
lisa-bengtsson:xr_cnvcld
May 7, 2024
Merged

Add xr_cnvcld flag to namelist and configure files#1
yangfanglin merged 2 commits into
yangfanglin:dycore_update_hr4from
lisa-bengtsson:xr_cnvcld

Conversation

@lisa-bengtsson
Copy link
Copy Markdown

This PR adds the namelist option xr_cnvcld into Fanglin's PR dycore_update_hr4. In order to use this namelist flag the version of the ufs-weather-model needs to include this update: ufs-community/ufs-weather-model#2202

export nthreads_fv3_gfs=1
export nthreads_ufs=1
export nthreads_ufs_gfs=1
export xr_cnvcld=.false. # Do not pass conv. clouds to Xu-Randall cloud fraction
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation needs adjustment

export nthreads_ufs_gfs=1
export cdmbgwd="0.14,1.8,1.0,1.0" # mountain blocking, ogwd, cgwd, cgwd src scaling
export xr_cnvcld=.false. # Do not pass conv. clouds to Xu-Randall cloud fraction
export cdmbgwd="0.14,1.8,1.0,1.0" # mountain blocking, ogwd, cgwd, cgwd src scaling
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation !

export nthreads_ufs_gfs=1
export cdmbgwd="0.071,2.1,1.0,1.0" # mountain blocking, ogwd, cgwd, cgwd src scaling
export xr_cnvcld=.false. # Do not pass conv. clouds to Xu-Randall cloud fraction
export cdmbgwd="0.071,2.1,1.0,1.0" # mountain blocking, ogwd, cgwd, cgwd src scaling
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

export nthreads_fv3_gfs=1
export nthreads_ufs=1
export nthreads_ufs_gfs=1
export xr_cnvcld=.false. # Do not pass conv. clouds to Xu-Randall cloud fraction
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Copy link
Copy Markdown
Owner

@yangfanglin yangfanglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lisa, the changes are good except a few indentations need to be adjusted

@lisa-bengtsson
Copy link
Copy Markdown
Author

I see, yes that looks odd. I will take a look.

Copy link
Copy Markdown
Owner

@yangfanglin yangfanglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@yangfanglin yangfanglin merged commit 9d73ba3 into yangfanglin:dycore_update_hr4 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants